Skip to content

test(a2a): name HTTP gateway scenarios - #3449

Draft
jjamroga wants to merge 4 commits into
kagent-dev:mainfrom
jjamroga:test/given-when-assert-that-http
Draft

jjamroga wants to merge 4 commits into
kagent-dev:mainfrom
jjamroga:test/given-when-assert-that-http

Conversation

@jjamroga

@jjamroga jjamroga commented Oct 30, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Apply the Given/When/AssertThat convention from docs(test): add Given/When/AssertThat testing skill #3448 to all 40 matrix scenarios in go/core/internal/a2agateway/http_test.go: conversation retries, missing conversations, URL authority, access failures, share access across transports, push retries, and Agent authorization.
  • Give the three single-case tests Given/When/AssertThat function names without adding redundant subtests. The seven matrix-test functions retain short behavior names as grouping labels.
  • Preserve the original permutations, setup, assertions, and cleanup. This remains a separate, test-only draft example for discussion; no production behavior or test coverage changes.

Validation

  • cd go/core && go run gotest.tools/gotestsum@v1.13.0 --format testname -- ./internal/a2agateway -count=1 — passed, 124 tests.
  • make -C go lint LINT_ARGS=./core/internal/a2agateway — passed, 0 issues.
  • gofmt -l go/core/internal/a2agateway/http_test.go — passed, no output.
  • git diff --check — passed.

Signed-off-by: Jonathan Jamroga <jjamroga@gmail.com>
@github-actions github-actions Bot added the testing Additional testing required label Oct 30, 2026
Signed-off-by: Jonathan Jamroga <jjamroga@gmail.com>
@jjamroga jjamroga changed the title test(a2a): name HTTP access cases as behavior scenarios test(a2a): name HTTP gateway scenarios Oct 30, 2026
@github-actions github-actions Bot added testing Additional testing required and removed testing Additional testing required labels Oct 30, 2026
Signed-off-by: Jonathan Jamroga <jjamroga@gmail.com>
@github-actions github-actions Bot added testing Additional testing required and removed testing Additional testing required labels Oct 30, 2026
Signed-off-by: Jonathan Jamroga <jjamroga@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Additional testing required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant