Skip to content

Helm chart sets env vars the server never reads #92

Open

Description

@dimetron

The chart sets these env vars, but the code never reads them:

  • PROMETHEUS_USERNAME / PROMETHEUS_PASSWORD: the password is a plain value, not a Secret, and no Prometheus tool sends auth.
  • GRAFANA_URL / GRAFANA_API_KEY: there is no Grafana provider (see the gcx issue).
  • OTEL_TRACING_ENABLED and OTEL_EXPORTER_OTLP_TRACES_TIMEOUT: the code reads OTEL_SDK_DISABLED, OTEL_SERVICE_NAME, etc. instead.
  • KAGENT_NAMESPACE

Either wire them up (with Prometheus basic auth coming from a Secret) or remove them from the chart and README. Found while reviewing #91.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions