fix(providers): don't crash on an empty choices list - #6705
Merged
Conversation
dosubot
Bot
added
size:XS
Contributor
|
🚀 Well done @chiruu12! Two PRs merged already! 🎉🥳 With your second PR, you're on a roll, and your contributions are already making a difference. 🌟 |
This was referenced Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6706
The litellm and vllm providers read
result["choices"][0]inside anexcept KeyError. An emptychoiceslist raises IndexError, which that handler doesn't catch, so the workflow step dies with an opaque traceback instead of the empty-response fallback the code already has for a missing content key.This shows up in normal operation. An OpenAI-compatible backend can return HTTP 200 with
{"choices": []}(Azure OpenAI does this when a prompt trips its content filter), soraise_for_status()passes and thenchoices[0]throws.Catches IndexError alongside KeyError in both providers, so an empty list falls back to
""the same way a missing key does. Added a regression test for the litellm path.