Repository navigation
Make live view usable on touch devices #448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
masnwilliams
wants to merge
25
commits into
main
Choose a base branch
from
hypeship/live-view-touch-input
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+3,966
−68
Open
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
9111131
Make live view usable on touch devices
masnwilliams 52d6c14
Keep the keyboard button above the soft keyboard and ignore stale cur…
masnwilliams facde55
Measure the keyboard inset against the player box
masnwilliams 7a77aa8
Keep the touch keyboard control off the stream
masnwilliams 0838a38
Place the keyboard control in pixels from its measured size
masnwilliams bc5599b
Reuse a known cursor shape when a tap lands on the same spot
masnwilliams 90ead0c
Only bind a cursor shape to a pointer position it can belong to
masnwilliams b978a25
Treat any text cursor after a tap as the keyboard signal
masnwilliams 4e938a0
Keep the keyboard when a tap lands on text under an unchanged I-beam
masnwilliams 77dd1eb
Raise the keyboard on iOS when the text cursor arrives after the tap
masnwilliams f4fc300
Drop a pending tap keyboard decision when a new touch begins
masnwilliams 3dc5b39
Merge branch 'main' into hypeship/live-view-touch-input
masnwilliams 194695e
Make touch ownership and keyboard decisions explicit in the live view
masnwilliams faa28e0
Release the mouse button when a drag is cancelled
masnwilliams dc352a9
Type soft keyboard capitals from the remote's Shift and Caps Lock state
masnwilliams fb56f3d
Turn the remote Caps Lock off when the soft keyboard opens
masnwilliams eef3025
Merge branch 'main' into hypeship/live-view-touch-input
masnwilliams 1562e45
Keep the video's scale above the soft keyboard, add a paste control, …
masnwilliams a13955c
Measure the keyboard pan from the player's layout position
masnwilliams 9fe86cf
Keep a possibly stale I-beam from raising the keyboard, and keep curs…
masnwilliams 4e7a9b7
Limit the stale cursor window to taps still waiting for their cursor
masnwilliams 04193d2
Drop on-page chips, close the keyboard after a submit, stop parking t…
masnwilliams 9f13cae
Keep the clipboard sync from replacing a pending Copy write
masnwilliams 5d6e96e
Add an extra keys row, paste through the remote clipboard, offer Copy…
masnwilliams 8903604
Close the soft keyboard before opening the clipboard panel on touch
masnwilliams File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.