fix(tree-compare): restore A/B details drawer on row click - #2081
Open
felipebergamin wants to merge 4 commits into
Open
felipebergamin wants to merge 4 commits into
felipebergamin wants to merge 4 commits into
Conversation
felipebergamin
marked this pull request as ready for review
September 8, 2026 18:50
Compare rows had no build/test IDs after AB shipped, so the side-by-side log sheet never opened. Return id_a/id_b from the diff APIs and open the drawer without the duplicate status chip. Closes kernelci#2060 Signed-off-by: Felipe Bergamin <felipebergamin@profusion.mobi>
PR kernelci#2069 widened compare rows to CompareRowChange, adding 'unchanged', but CompareDetailItem still pinned change to CompareChangeType, so the merge with main failed typecheck. Derive it from CompareFailureRow so the drawer follows the row classification instead of duplicating it. Signed-off-by: Felipe Bergamin <felipebergamin@profusion.mobi>
Next/prev used the change-filter list, so table search was ignored. Own the sheet in each table and share LogSheetPanel with the existing log drawer.
felipebergamin
force-pushed
the
fix/2060/ab-comparison-drawer
branch
from
September 14, 2026 18:01
601227a to
ee6bd2e
Compare
alanpeixinho
approved these changes
Sep 15, 2026
| nextItem: onNext, | ||
| hasPrevious, | ||
| hasNext, | ||
| isLoading: false, |
Contributor
There was a problem hiding this comment.
shouldnt we get the isLoading state from the data fetch?
Use the log queries' isLoading instead of a hardcoded false so keyboard next/prev waits until both sides have loaded.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compare rows had no build/test IDs after AB shipped, so the side-by-side log sheet never opened. Return id_a/id_b from the diff APIs and open the drawer without the duplicate status chip.
Closes #2060
Visual reference