feat(api): wire per-tab lab filters and metrics lab health (#2059) - #2107
Open
alanpeixinho wants to merge 1 commit into
Open
alanpeixinho wants to merge 1 commit into
alanpeixinho wants to merge 1 commit into
Conversation
…2059) * filter_test.lab, filter_boot.lab, and filter_build.lab handlers with per-tab filter_labs * Lab filtering on tree, hardware, rollup, and commits history listings * Hardware POST filter body support for lab per boot/test/build tab * lab_maps builds/boots/tests as StatusCount on /api/metrics/ * covered_builds int on LabMetricsData * Faster covered-builds SQL via nested GROUP BY lab, build_id * Metrics email template, Metrics page, and frontend filter types updates * Unit tests for filters, metrics queries, notifications, and rollup Signed-off-by: Alan Peixinho <alan.peixinho@profusion.mobi>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it is
Closes #2059. Per-tab lab filters for tree and hardware APIs (
filter_test.lab,filter_boot.lab,filter_build.lab), including hardware POSTfilterbodies./api/metrics/lab_mapsnow exposes per-labStatusCountfor builds, boots, and tests, pluscovered_buildsfor the email “Covered builds” column. Covered-builds SQL uses nestedGROUP BY lab, build_id.What to test
boots/tests/builds:filter_boot.lab,filter_test.lab,filter_build.lab(query + POST where supported); builds filter on build lab, not test labboots/tests/builds/summary: POSTfilterwith per-tab lab keys; lab + status togetherGET /api/metrics/: response includes newcovered_buildson each lab entry, andbuilds/boots/testsasStatusCountobjects (not plain ints)metrics_summaryemail: “Covered builds” totals and per-lab values match pre-change behaviour; boots/tests columns unchangedtest.labandboot.labstill work; builds tab not lab-filtered via UI (by design)Made with Cursor