build(mobile): harden gobuild.sh and go bind pipeline#29364
Open
chrisnojima wants to merge 1 commit into
Open
Conversation
chrisnojima
commented
Jul 2, 2026
chrisnojima
commented
Contributor
- propagate gomobile bind failures: the output-sniffing retry heuristic discarded exit codes, so failed builds could exit 0 with stale artifacts
- stop using gomobile init: it installs gobind@latest, skewing against the x/mobile version pinned in go.mod; install pinned gobind directly
- patch gobind's @import Foundation at generation time in gobuild.sh instead of yarn postinstall; delete dead fixModules docgen stub
- add -trimpath; bump x/mobile to 20260611
- drop 32-bit x86 ABI from aar and gradle (dead hardware); keep armeabi-v7a
- faster local iteration: android-debug.sh builds only the connected device's ABI, gobuild.sh takes a TARGETS override
- replace no-op GOTRACEBACK setenv in bind Init with SetTraceback("crash")
- propagate gomobile bind failures: the output-sniffing retry heuristic discarded exit codes, so failed builds could exit 0 with stale artifacts - stop using gomobile init: it installs gobind@latest, skewing against the x/mobile version pinned in go.mod; install pinned gobind directly - patch gobind's @import Foundation at generation time in gobuild.sh instead of yarn postinstall; delete dead fixModules docgen stub - add -trimpath; bump x/mobile to 20260611 - drop 32-bit x86 ABI from aar and gradle (dead hardware); keep armeabi-v7a - faster local iteration: android-debug.sh builds only the connected device's ABI, gobuild.sh takes a TARGETS override - replace no-op GOTRACEBACK setenv in bind Init with SetTraceback("crash")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.