sharing cleanup#29366
Open
chrisnojima wants to merge 4 commits into
Open
Conversation
The linking rewrite dropped the convID segment of keybase://incoming-share/<convID>, so picking a donated conversation in the iOS share sheet fell back to the generic picker. Pass it as selectedConversationIDKey again (was in constants/deeplinks, see 02c5535).
- share one IncomingShareHeaderTitle between routes and screen - remove originalOnly store-sync effect from OriginalOrCompressedButton; both mount sites already skip mounting it when originalOnly - clear consumed androidShare on unmount so getInitialURL can't resurface a stale share later in the session - misc: footer returns JSX, merged prop types, ignorePromise, dead capitalize param
- collapse onCreate/onNewIntent duplication into captureIntent - drop normalizeShareIntent and handleIntent's re-extract fallbacks: pendingShare* is always populated for SEND intents and only consumed once, so the fallbacks were unreachable - copy shared files on a background thread; content-provider reads of large files were blocking the main thread (ANR risk) - remove didSomething and the notification bundle clone dance
png/gif/jpeg/heic shares went through the plain file path with no scaledPath, so the full-size/compress choice never appeared for most photo shares; only coerced images and videos were scaled. Route them through sendMedia -> MediaUtils.processImage like videos. If scaling fails (odd/corrupt format) fall back to a plain file entry instead of erroring the share. Compressing a GIF yields a static jpg; keeping full size preserves the original. Also collapse the duplicated processVideo/processImage completion and delete unused closeProgressView.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.