refactor(desktop): simplify remote window plumbing#29367
Open
chrisnojima wants to merge 1 commit into
Open
Conversation
The main process now owns a remote-window registry and a cache of the last props sent per window. Windows pull cached props when they load, which replaces the wants-props handshake through the main window (and its config-store counter map) and the racy find-window-by-URL retry loop. - darkMode now rides along in the serialized props envelope and is applied by the component loader, instead of being hand-plumbed through every proxy and wrapper - remote action handlers live in a module-level map instead of a zustand store, so they survive the store reset at logout (the old registry silently dropped pinentry/tracker handlers there) - all remote windows share one webpack entry (remote.html?component=) with per-component lazy chunks, replacing four separate entries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main process now owns a remote-window registry and a cache of the last props sent per window. Windows pull cached props when they load, which replaces the wants-props handshake through the main window (and its config-store counter map) and the racy find-window-by-URL retry loop.