refactor(router-v2): dedupe nav plumbing, drop dynamic route path#29368
Open
chrisnojima wants to merge 1 commit into
Open
refactor(router-v2): dedupe nav plumbing, drop dynamic route path#29368chrisnojima wants to merge 1 commit into
chrisnojima wants to merge 1 commit into
Conversation
chrisnojima
commented
Jul 3, 2026
chrisnojima
commented
Contributor
- share useUserSwitchNavKey, tabToTestID, and NavigationContainer callbacks between desktop and native routers
- migrate settings and crypto sub-navs to static config; custom navigator factories accept static config in RN8, so the JSX-element route path (routeMapToScreenElements) is deletable
- delete dead hooks.native.tsx, unused props/refs, identical wrapper components
- fix module.hot.accept('') — empty string landed in the callback slot; plain self-accept was the intent
- share useUserSwitchNavKey, tabToTestID, and NavigationContainer
callbacks between desktop and native routers
- migrate settings and crypto sub-navs to static config; custom
navigator factories accept static config in RN8, so the JSX-element
route path (routeMapToScreenElements) is deletable
- delete dead hooks.native.tsx, unused props/refs, identical wrapper
components
- fix module.hot.accept('') — empty string landed in the callback
slot; plain self-accept was the intent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.