[tungleduyxyz]

Summary

• Add a Roles page listing role definitions, using Kill Bill's GET /1.0/kb/security/roles (Kill Bill 0.25+). On older servers the page shows "Listing roles requires Kill Bill 0.25 or later."
• Add edit and update of a role's permissions, reusing the role form (role name read-only, "Update Role" button)
• Add Roles links in the settings sidebar, the navbar menu and the home dashboard
• An unknown role opens a "was not found" message instead of an empty form (Kill Bill answers 200 with no permissions for unknown roles)

Fixes #161

Depends on

• Add RoleDefinition.find_all to list role definitions killbill-client-ruby#124 adds RoleDefinition.find_all. The list page needs a client release that contains it.

Testing

• rails t test/functional/kaui/role_definitions_controller_test.rb: 9 runs, 44 assertions, 0 failures, against Kill Bill 0.25.4 on Tomcat 11 (client from the local checkout of the PR above)
• In the browser against Kill Bill 0.25.4: created a role, saw it listed, edited its permissions and saved; the list showed the update
• On Kill Bill 0.24.16: edit and update work, the list shows the 0.25+ message
• The functional test setup needs Kill Bill's bus polling lowered (-Dorg.killbill.persistent.bus.main.sleep=100 -Dorg.killbill.persistent.bus.external.sleep=100 -Dorg.killbill.notificationq.main.sleep=100), otherwise callCompletion requests return 408

Notes

• The role form's submit label on the create page is still "Save User"; Fix role save label, amount placeholder, and Aviate catalog delete button #674 changes it to "Save Role", so expect a small merge conflict on that line.