Repository navigation
Show invoice amount and balance on the account invoices page - #681
Draft
tungleduyxyz wants to merge 1 commit into
Draft
tungleduyxyz wants to merge 1 commit into
tungleduyxyz wants to merge 1 commit into
Conversation
The paginated account invoices API returns shallow invoices, so amount and balance were not usable. Kill Bill can now load the invoice components for the invoices of the requested page only (includeInvoiceComponents). - List Amount and Balance in Edit Columns (hidden by default) - Only ask for the components when one of these columns is visible, and reload the page when one of them is turned on - CSV download requests them when amount/balance are exported, so the export matches what the UI displays Requires killbill/killbill#2334 and killbill/killbill-client-ruby#128. Closes #678 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #678. The paginated account invoices API returns shallow invoices, so Amount and Balance were not usable. This uses the new
includeInvoiceComponentsoption, which loads the components for the invoices of the requested page only, so the cost depends on the page size, not on the account's invoice count.amountandbalanceare listed like the other columns (hidden by default, so default behavior andDEFAULT_VISIBLE_COLUMNSare unchanged).include_invoice_components=truewhen Amount or Balance is visible, and reloads the current page when one of them is turned on.amount/balanceare exported (or all fields), so the export matches the UI.Draft: blocked on releases
includeInvoiceComponents)Account.paginated_invoices)This calls
paginated_invoiceswith the new argument, so it needs a killbill-client release (and a Gemfile.lock bump) before it can pass CI/merge.Testing
Added controller tests (flag plumbing with a stubbed API; column list and default visibility). I could not run the functional tests locally: they need a Kill Bill server. The UI behavior (column toggle reload) is untested in a browser.
🤖 Generated with Claude Code