Fix parsing RPL_WHOISACTUALLY on some networks.#415
Open
sadiepowell wants to merge 1 commit into
Open
Conversation
sadiepowell
force-pushed
the
fix-whoisactually
branch
from
577ebf0 to
e67140d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Libera.Chat only sends an IP address and no hostname in this numeric. UnrealIRCd has also fixed their numeric reuse so I've updated the comment to reflect that.
Currently there are three valid forms of the numeric and all of these should now be supported:
<source> 338 <target> <nick> <user>@<host> <ip> :Actual user@host, Actual IP<source> 338 <target> <nick> <host> <ip> :Actual user@host, Actual IP<source> 338 <target> <nick> <ip> :Actual IPTested using my fork of The Lounge.
Note: Event handlers in irc-fw are not particularly robust to unexpected behaviour from servers and it'd probably be good to have a method for command parameter validation that could check the parameter count and then on error dispatch to an common error event and throw something handleable by
executeCommand. I can submit a pull request for this if you're interested.