Skip to content

relax test expectation for PHP 8.6 - #109

Open
remicollet wants to merge 1 commit into
kjdev:masterfrom
remicollet:issue-8.6.0beta1
Open

relax test expectation for PHP 8.6#109
remicollet wants to merge 1 commit into
kjdev:masterfrom
remicollet:issue-8.6.0beta1

Conversation

@remicollet

@remicollet remicollet commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Path is no more traced in PHP 8.6+

========DIFF========
     Warning: readfile(): https:// wrapper is disabled in the server configuration by allow_url_fopen=0 in %s
     
003- Warning: readfile(https://github.com/kjdev/php-ext-zstd/raw/master/tests/streaming.zst): %sailed to open stream: no suitable wrapper could be found in %s
003+ Warning: readfile(): Failed to open stream: no suitable wrapper could be found in /dev/shm/BUILD/php86-php-zstd-0.18.0-build/php86-php-zstd-0.18.0/php-ext-zstd-0.18.0/tests/streams_7.php on line 2
     
005- Warning: readfile(compress.zstd://https://github.com/kjdev/php-ext-zstd/raw/master/tests/streaming.zst): %sailed to open stream: operation failed in %s
005+ Warning: readfile(): Failed to open stream: operation failed in /dev/shm/BUILD/php86-php-zstd-0.18.0-build/php86-php-zstd-0.18.0/php-ext-zstd-0.18.0/tests/streams_7.php on line 2
     
     ===Done===
========DONE========
FAIL compress.zstd read online stream denied [tests/streams_7.phpt] 

Summary by CodeRabbit

  • Bug Fixes
    • Updated expected warning messages for readfile() tests to reflect current error output.
    • Improved test coverage for variable stream paths, including compressed and HTTPS streams.

@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 20b8b75d-8c79-4093-aca1-fd6dae8bcbdc

📥 Commits

Reviewing files that changed from the base of the PR and between c2593a4 and eeb9421.

📒 Files selected for processing (1)
  • tests/streams_7.phpt

📝 Walkthrough

Walkthrough

The stream test updates both readfile() warning expectations to accept variable stream paths instead of fixed HTTPS and compress.zstd URLs.

Changes

Stream warning test

Layer / File(s) Summary
Generalize warning path matching
tests/streams_7.phpt
The test uses %s placeholders for paths in both stream-opening warnings.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to eeb94

This is a narrowly scoped test-expectation update for PHP 8.6 behavior, with no actionable merge-blocking risk remaining beyond normal checks and review.

Possibly related issues

  • kjdev/php-ext-zstd issue 103: Both changes update tests/streams_7.phpt expectations for PHP versions that remove stream paths from readfile() errors.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the test expectation change for PHP 8.6.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant