Simplify CI workflows: remove legacy GOPATH checkout pattern#4597
Open
aravindtga wants to merge 1 commit into
Open
Simplify CI workflows: remove legacy GOPATH checkout pattern#4597aravindtga wants to merge 1 commit into
aravindtga wants to merge 1 commit into
Conversation
Signed-off-by: Aravindhan Ayyanathan <aravindhan.a@est.tech>
✅ Deploy Preview for kptdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the GitHub Actions CI/release workflows to remove the legacy GOPATH-style checkout layout and associated working-directory overrides, relying on standard Go modules behavior from the repository root.
Changes:
- Removed GOPATH-style checkout paths and
working-directorydirectives across multiple workflows so jobs run from the default workspace root. - Simplified
actions/setup-go@v6configuration by usinggo-version-filepaths relative to the repo root and dropping explicit cache settings where not needed. - Updated the release workflow to replace deprecated
::set-outputusage with$GITHUB_OUTPUTand removed the GoReleaser actionworkdir.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/verifyContent.yml | Drops GOPATH checkout path and runs build/verify steps from repo root with go-version-file: go.mod. |
| .github/workflows/release.yml | Removes GOPATH checkout/workdir usage and replaces deprecated step output with $GITHUB_OUTPUT. |
| .github/workflows/release-api.yml | Switches API release workflow to repo-root checkout while still targeting the api/ module via go-version-file. |
| .github/workflows/live-e2e.yml | Removes GOPATH checkout and working-directory, running e2e from repo root. |
| .github/workflows/go.yml | Removes top-level GOPATH env and GOPATH-based checkout paths for Linux/macOS jobs. |
| .github/workflows/e2eEnvironment.yml | Removes GOPATH checkout and working-directory, running e2e from repo root. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What changed:
path: go/src/github.com/kptdev/kpt), the top-levelGOPATHenv variable, and all associatedworking-directorydirectives from 6 workflow files.actions/setup-go@v6configuration by dropping explicitcache: trueandcache-dependency-pathwhere defaults suffice.cache-dependency-path: api/go.suminrelease-api.ymlfor the submodule.::set-outputinrelease.ymlwith$GITHUB_OUTPUT.workdirfromgoreleaser/goreleaser-action@v6inrelease.yml.Why it's needed: The project uses Go modules, the GOPATH checkout layout is unnecessary legacy from the pre-modules era. It adds verbosity and fragility to every workflow. The
::set-outputdeprecation will eventually break release builds.How it works: With Go modules,
gocommands work from any directory containinggo.mod. Checking out to the default workspace root eliminates the need for custom paths andworking-directoryoverrides.Type of Change
Checklist
AI Disclosure
If so, please describe how:
- Kiro to identify the unnecessary GOPATH pattern across all workflow files and to generate PR message.