Skip to content

Don't print env-supplied secrets in flag usage - #1004

Merged
kubernetes-prow[bot] merged 1 commit into
kubernetes:masterfrom
locker95:hide-env-flag-defaults
Oct 23, 2026
Merged

Don't print env-supplied secrets in flag usage#1004
kubernetes-prow[bot] merged 1 commit into
kubernetes:masterfrom
locker95:hide-env-flag-defaults

Conversation

@locker95

@locker95 locker95 commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

--repo, --credential, and --askpass-url take their defaults from the environment. pflag then prints that default in --help and when flag parsing fails, so a token in GITSYNC_REPO or GITSYNC_CREDENTIAL lands in the sidecar log.

The startup line already redacts these. This only changes the text pflag shows for the default, and only when the env var is actually set. An empty --credential still prints []. The value that gets parsed is unchanged.

Fixes #1001

@kubernetes-prow kubernetes-prow Bot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 1, 2026
@kubernetes-prow

kubernetes-prow Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Welcome @locker95!

It looks like this is your first PR to kubernetes/git-sync 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/git-sync has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@kubernetes-prow
kubernetes-prow Bot requested review from sdowell and stp-ip October 1, 2026 08:33
@kubernetes-prow kubernetes-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 1, 2026
@kubernetes-prow kubernetes-prow Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 9, 2026
@locker95
Don't print env-supplied secrets in flag usage
1d31866 
--repo, --credential, and --askpass-url take defaults from environment
variables. pflag echoes DefValue on --help and parse errors, so a token
in those variables shows up in the sidecar log. Replace the displayed
default when the env var is set; the value that is parsed stays put.

Signed-off-by: Dean Chen <862469039@qq.com>
@locker95
locker95 force-pushed the hide-env-flag-defaults branch from 9d64365 to 1d31866 Compare October 12, 2026 16:12
@kubernetes-prow kubernetes-prow Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 12, 2026
@thockin

thockin commented Oct 23, 2026

Copy link
Copy Markdown
Member

/approve
/lgtm

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 23, 2026
@kubernetes-prow

kubernetes-prow Bot commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: locker95, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2026
@kubernetes-prow
kubernetes-prow Bot merged commit 5d5eb54 into kubernetes:master Oct 23, 2026
5 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Oct 24, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sdowell sdowell Awaiting requested review from sdowell
@stp-ip stp-ip Awaiting requested review from stp-ip

Assignees

@thockin thockin

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Secret-bearing flag defaults (--credential, --repo, --askpass-url) are printed in cleartext in usage output

2 participants

@locker95 @thockin