Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant enhancements and new features to the DSP module, focusing on advanced oversampling, oscillator, and filter capabilities, along with improvements to examples and documentation. Notably, it adds a new halfband oversampler, major oscillator classes for alias-free synthesis, a state-of-the-art state variable filter, and upgrades to the example synthesizer instruments and displays. Documentation has been updated to reflect these changes and to provide comprehensive coverage of the new APIs.
DSP Module Enhancements:
HalfbandOversampler, a new power-of-two oversampler with both linear-phase FIR and polyphase IIR designs, offering improved efficiency and flexibility for audio processing. ([CHANGELOG.mdR427-R442](https://github.com/kunitoki/yup/pull/192/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4edR427-R442))OversamplertoSincOversampler, significantly improving its speed and alias rejection, and expanded the available oversampling factors and kernel radii. ([[1]](https://github.com/kunitoki/yup/pull/192/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4edR410),[[2]](https://github.com/kunitoki/yup/pull/192/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4edR427-R442))FourierSeries,SyncSpectralResampler,AdditiveOscillator,WavetableOscillator, andSyncOscillator, enabling alias-free oscillator synchronization and advanced spectral shaping (PrismSpectrum), as well as a newLFOclass. ([[1]](https://github.com/kunitoki/yup/pull/192/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4edR427-R442),[[2]](https://github.com/kunitoki/yup/pull/192/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4edR451-R452))VAStateVariableFilter, a topology-preserving transform SVF supporting eight outputs, analytic response, and advanced resonance and shelf controls. ([[1]](https://github.com/kunitoki/yup/pull/192/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4edR427-R442),[[2]](https://github.com/kunitoki/yup/pull/192/files#diff-435ffb471327778d19da9c282345a72219bb8683a8cebaead5acca3499ae0492R150-R173))Example and Demo Improvements:
[[1]](https://github.com/kunitoki/yup/pull/192/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4edR427-R442),[[2]](https://github.com/kunitoki/yup/pull/192/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4edR824-R833))[CHANGELOG.mdR427-R442](https://github.com/kunitoki/yup/pull/192/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4edR427-R442))Documentation Updates:
[[1]](https://github.com/kunitoki/yup/pull/192/files#diff-f0388ca6e731ed5b28d7294ea9023718fa9f2969d34a3a604cb77c72c31d3167L6-R6),[[2]](https://github.com/kunitoki/yup/pull/192/files#diff-f0388ca6e731ed5b28d7294ea9023718fa9f2969d34a3a604cb77c72c31d3167L32-R32),[[3]](https://github.com/kunitoki/yup/pull/192/files#diff-f0388ca6e731ed5b28d7294ea9023718fa9f2969d34a3a604cb77c72c31d3167L44-R52),[[4]](https://github.com/kunitoki/yup/pull/192/files#diff-f0388ca6e731ed5b28d7294ea9023718fa9f2969d34a3a604cb77c72c31d3167R115),[[5]](https://github.com/kunitoki/yup/pull/192/files#diff-435ffb471327778d19da9c282345a72219bb8683a8cebaead5acca3499ae0492R150-R173))[[1]](https://github.com/kunitoki/yup/pull/192/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4edR410),[[2]](https://github.com/kunitoki/yup/pull/192/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4edR427-R442),[[3]](https://github.com/kunitoki/yup/pull/192/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4edR451-R452),[[4]](https://github.com/kunitoki/yup/pull/192/files#diff-06572a96a58dc510037d5efa622f9bec8519bc1beab13c9f251e97e657a9d4edR824-R833))Build System:
compile_commands.jsonfor improved tooling support. ([CMakeLists.txtR31](https://github.com/kunitoki/yup/pull/192/files#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20aR31))These changes collectively advance the DSP framework's capabilities for real-time audio synthesis and processing, and provide a richer set of tools for both developers and users.