Conversation
rIndex defaulted to 0 and the delete executed unconditionally. When the normalized lookup path didn't match any stored raw path (e.g. 'users' stored without a leading slash), r.routes[0] was silently deleted while the dead entry remained.
Contributor
|
but where is the test-case? |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3097 +/- ##
==========================================
+ Coverage 93.34% 95.71% +2.36%
==========================================
Files 43 44 +1
Lines 4735 4036 -699
==========================================
- Hits 4420 3863 -557
+ Misses 192 173 -19
+ Partials 123 0 -123 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug
DefaultRouter.Removesearchedr.routesfor the normalized path butAddstores the raw path. When they differ (e.g.e.GET("users", h)without a leading slash),rIndexstayed at 0 andr.routes[0]— a completely unrelated route — was silently deleted from the route listing while the dead entry remained.Fix
Return
nilwhen no matching entry is found instead of deletingr.routes[0]unconditionally.