Repository navigation
fix: account for every offered read operation in benchmarks - #13
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Companion product changes: labstack/pitot#473
Read reports can hide scheduler misses and queue delay, and count drain completions toward the offered load. Account for every scheduled arrival and qualify reads using completion time from the scheduled arrival.
Report intended and performed operation kinds, including fallback attribution. Add the proposed
interactive-http-draft/v1per-kind p95/p99 profile to workload metadata and qualification. Preserve historical service-time fields; legacy and undersampled reports cannot qualify against the new profile.Evidence
After: tests reconcile every offered/dispatched outcome, delayed scheduling, fallback mix, queue and completion latency, phase cutoff/drain, profile matching, and the 1,000-successful-samples-per-kind gate.
go test ./...,go test -race ./...,go vet ./..., and staged secret scanning.Merge Danger
Door: two-way
New read qualification is intentionally stricter. Standard short sweeps may use the documented best-completion topology fallback because they cannot provide enough p99 samples. Published measurements are not rewritten.
Blast Radius: reporting
Changes read-load scheduling, mixed-topology eligibility, report metadata and qualification; ingest measurement is unchanged.