fix: bound commit conflict retry backoff - #8169
Merged
Merged
Conversation
Contributor
Author
There was a problem hiding this comment.
Gate recommendation: approve. The change addresses the unbounded latency-scaled sleep at the commit boundary, applies one remaining-time budget across attached and detached retry backoff, and preserves commit-outcome verification before cleanup. Reusing the existing timeout semantics is preferable to changing SlotBackoff globally because unrelated contention behavior remains unchanged.
Xuanwo
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
commit_transaction derived SlotBackoff delays from the first attempt latency but awaited each delay directly. A slow first attempt could therefore produce a backoff sleep longer than the intended retry wall-clock budget.
Validation
Fixes #7882