fix(java): type scanner operation failures - #8184
Merged
Merged
Conversation
Contributor
Author
There was a problem hiding this comment.
✅ Gate recommendation: approve.
The change establishes a compatible typed failure boundary for synchronous stream creation and asynchronous native/import failures while preserving available causes and leaving programming-state exceptions distinct. A checked exception cannot fit Arrow’s Scanner override or CompletableFuture, and a global JNI remap would alter unrelated APIs, so the focused Java-boundary wrapper is the preferable mechanism.
Xuanwo
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
LanceScanner and AsyncScanner converted scanner I/O and native-operation failures into bare RuntimeException instances. Callers therefore could not distinguish Lance operation failures from unrelated programming errors.
Validation
Fixes #7611