fix(index): push down deeply nested scalar filters - #8186
Merged
Conversation
Contributor
Author
There was a problem hiding this comment.
✅ Gate recommendation: approve.
The change fixes the optimizer-boundary mismatch at the narrow path-extraction boundary while preserving chained access, canonical nested-field formatting, and safe fallback for malformed expressions. This is preferable to broader planner normalization because it covers every expression producer without changing planner or format contracts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_fieldexpressionsget_fieldsupport and canonical nested field formattingRoot cause
DataFusion optimization combines deeply nested field access into one variadic
get_fieldcall. The scalar-index path extractor required exactly two arguments, returned no path for depth two or greater, and left the filter as a full-scan refinement.Validation
cargo fmt --all -- --checkcargo test -p lance-index(925 passed, 2 ignored; 7 doctests passed)cargo clippy --all --tests --benches -- -D warningsFixes #8170