Skip to content

fix(index): initialize indices on nested fields - #8192

Merged
Xuanwo merged 1 commit into
mainfrom
gatekeeper/fix-8149-1
Aug 3, 2026
Merged

fix(index): initialize indices on nested fields#8192
Xuanwo merged 1 commit into
mainfrom
gatekeeper/fix-8149-1

Conversation

@lance-gatekeeper

Copy link
Copy Markdown
Contributor

Summary

  • preserve the canonical schema field path while initializing an index
  • use the full path for target validation and scalar or vector index creation
  • cover simple nested fields and nested fields that require path quoting

Root cause

initialize_index resolved each source field by ID but then used only the leaf field name. This discarded the parent path and canonical quoting before the target lookup and index initializer ran.

Validation

  • cargo test -p lance --lib test_initialize_
  • cargo fmt --all -- --check
  • cargo clippy --all --tests --benches -- -D warnings

Fixes #8149

@github-actions github-actions Bot added the bug Something isn't working label Aug 3, 2026

@lance-gatekeeper lance-gatekeeper Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gate recommendation: approve.

Resolving source field IDs to canonical schema paths at the shared initialization boundary preserves parent segments and quoting for target validation and both scalar and vector initialization, without changing stored index metadata or public semantics.

@Xuanwo Xuanwo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

@Xuanwo
Xuanwo merged commit d5050ad into main Aug 3, 2026
39 of 40 checks passed
@Xuanwo
Xuanwo deleted the gatekeeper/fix-8149-1 branch August 3, 2026 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: initialize_index fails for nested index fields

1 participant