Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Dataset media references under numeric object keys are left as raw strings when the Python SDK loads a dataset. The backend's
jsonpath-plusemits$[0]for both an array index and an object key"0"; it emits$[00]for the distinct object key"00".Resolve numeric segments according to the current container and preserve leading zeroes. Missing object keys still raise instead of creating a new entry. Existing array indices continue to use integers.
The regression tests cover numeric keys at leaf and intermediate positions, leading zeroes, mixed arrays and objects, and the dataset hydration path. I confirmed the examples against the backend's
jsonpath-plus10.3.0. There is no linked issue for this independently reproduced bug.Type of change
Verification
The affected tests reproduced failed hydration before the fix. Afterward, 38 focused tests and 1,021 unit tests passed; 2 unit tests were skipped. The first broad run timed out in the prompt-shutdown test during concurrent checks. That test and the full suite passed on a rerun with the project environment on
PATH. Live provider and server-backed E2E tests were not run.Checklist
code_review.md.

Confidence Score: 5/5
The PR appears safe to merge.Summary
Fixes dataset media references under numeric object keys.
Reviews (1) · Last reviewed commit: "fix(datasets): hydrate media under numer..." · Reviewed by Greptile