Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Author
|
Moved |
5 of 6 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
End an OpenAI observation when cancellation interrupts the awaited request before a response arrives, then re-raise the original cancellation. Previously, the SDK propagated cancellation but Langfuse never ended or exported that observation.
The same wrapper covers chat completions, Responses, and embeddings. Cancellation after a stream returns continues through the existing stream finalizer.
Type of change
Verification
Five regressions use real
AsyncOpenAIclients with a waiting HTTP mock transport and the in-memory exporter. All five fail on main because no ended observation is exported, and pass here. They retain the cancellation object/message and record no invented output, usage, cost, or error status.Python 3.13.18, locked OpenAI 2.29.0 and HTTPX 0.28.1:
The full suite uses the existing tracked fixtures and public CI dummy credentials. Lint, formatting, mypy, independent base/head replay, and diff review pass. Live-provider/server suites were not run; this behavior is covered by exporter-local unit tests.
Checklist
code_review.md..env.templateif needed. (Not applicable.)

Confidence Score: 5/5
The PR appears safe to merge.Summary
Ends OpenAI observations when cancellation interrupts a request before a response, then re-raises the original cancellation.
Reviews (2) · Last reviewed commit: "test(openai): move cancellation transpor..." · Reviewed by Greptile