Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions langfuse/langchain/CallbackHandler.py
Original file line number Diff line number Diff line change
Expand Up @@ -1820,6 +1820,18 @@ def _parse_usage(response: LLMResult) -> Any:


def _parse_model(response: LLMResult) -> Any:
# llm_output["model_name"] can be the configured alias, so prefer the
# model the provider reported on the generation
if response.generations and response.generations[-1]:
generation = response.generations[-1][-1]
message = getattr(generation, "message", None)
for metadata in (
getattr(message, "response_metadata", None),
generation.generation_info,
):
if isinstance(metadata, dict) and metadata.get("model_name"):
return metadata["model_name"]

# langchain-anthropic uses the usage field
llm_model_keys = ["model_name"]
llm_model = None
Expand Down
32 changes: 32 additions & 0 deletions tests/unit/test_langchain.py
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,38 @@ def test_chat_model_callback_exports_generation_span(
}


def test_chat_model_generation_uses_model_reported_in_response(
langfuse_memory_client, get_span
):
response = ChatResult(
generations=[
ChatGeneration(
message=AIMessage(
content="bonjour",
response_metadata={"model_name": "gpt-4o-2024-08-06"},
),
text="bonjour",
)
],
llm_output={"model_name": "azure.gpt-4o"},
)

with patch.object(ChatOpenAI, "_generate", return_value=response):
handler = CallbackHandler()
ChatOpenAI(api_key="test", model="azure.gpt-4o").invoke(
[HumanMessage(content="hello")],
config={"callbacks": [handler]},
)

langfuse_memory_client.flush()
generation_span = get_span("ChatOpenAI")

assert (
generation_span.attributes[LangfuseOtelSpanAttributes.OBSERVATION_MODEL]
== "gpt-4o-2024-08-06"
)


def test_chat_model_input_keeps_message_names(
langfuse_memory_client, get_span, json_attr
):
Expand Down
Loading