Improve browser navigation interactions#3
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8e39b0ed80
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
💡 Codex ReviewBlazor.HashRouting/src/Blazor.HashRouting/wwwroot/hash-routing.module.js Lines 350 to 352 in 6e3728e When Blazor.HashRouting/src/Blazor.HashRouting/wwwroot/hash-routing.module.js Lines 452 to 454 in 6e3728e
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
💡 Codex ReviewBlazor.HashRouting/src/Blazor.HashRouting/wwwroot/hash-routing.module.js Lines 359 to 360 in 781de7b After a successful temporary revert, the code re-applies the user navigation with ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2a20c8d3ea
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| resolverEntry.timeoutId = setTimeout(function () { | ||
| removeSuppressedBrowserNavigationEventResolver(resolverEntry); | ||
| resolve(false); | ||
| }, suppressedBrowserNavigationTimeoutMilliseconds); |
There was a problem hiding this comment.
Avoid hard-failing suppressed history waits after 100ms
The suppression wait currently times out after a fixed 100ms, which is short enough that legitimate popstate/hashchange events can arrive late on throttled or busy browsers. In that case the resolver is removed and navigation is treated as a failed revert/reapply, and when the delayed browser event finally arrives it is no longer suppressed and can be processed as a separate navigation. This can cause missed or out-of-order NotifyLocationChangedFromJs behavior during locked back/forward navigation under load.
Useful? React with 👍 / 👎.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Improve browser navigation Blazor hooks to prevent quick navigations from being ignored by Blazor.