chore(main): release 4.17.0#287
Merged
tanderson-ld merged 1 commit intoJun 4, 2026
Merged
Conversation
LaunchDarklyReleaseBot
force-pushed
the
release-please--branches--main--components--launchdarkly_flutter_client_sdk
branch
from
b0ab886 to
59351f2
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 59351f2. Configure here.
tanderson-ld
reviewed
Jun 4, 2026
Contributor
There was a problem hiding this comment.
Not sure why this change is triggering by release-please. Need to investigate.
Contributor
There was a problem hiding this comment.
Resolved by using generic updater for this file. Fix merged in #288
2 tasks
tanderson-ld
added a commit
that referenced
this pull request
Jun 4, 2026
… config (#288) ## Summary - Restores the intent of #117 after the release-please-action v3 → v5 upgrade in #262 silently changed the default updater behavior for `.yaml` files in `extra-files`. - Spells out `{ "type": "generic", "path": "example/pubspec.yaml" }` so the generic, marker-based updater is used explicitly — independent of whatever release-please core decides to default to. ## Background Under release-please-action **v3**, a bare-string `extra-files` entry like `"example/pubspec.yaml"` resolved to the **generic** line-based updater. That updater honors `# x-release-please-version` markers and does pure textual replacement, leaving comments and formatting alone. Every release from 4.1.0 through 4.16.0 produced a clean one-line bump to `example/pubspec.yaml`. PR #262 upgraded release-please-action to **v5**, which ships a much newer release-please core. In that version, bare-string entries are dispatched by file extension — and `.yaml` now binds to the **YAML updater**, which parses + re-serializes the file. The result is what we see in PR #287: ~80 lines deleted (all comments, blank lines, and the `# x-release-please-version` marker itself), the dep pin no longer bumps because its marker got stripped, and the example app's `version:` got rewritten to the SDK version. This is the exact failure mode #117 originally fixed back in January 2024. Making the updater type explicit is the minimal fix; once this lands, release-please will regenerate PR #287 (the 4.17.0 release PR) and produce a clean diff to `example/pubspec.yaml`. ## Test plan - [ ] Merge this PR to main - [ ] Confirm release-please regenerates PR #287 and that `packages/flutter_client_sdk/example/pubspec.yaml` shows only the dep-line bump (`4.16.0` → `4.17.0`), with all comments and the `# x-release-please-version` marker preserved <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Single release-automation config change with no runtime or application code impact. > > **Overview** > **Release-please config** for `packages/flutter_client_sdk` now declares `example/pubspec.yaml` as an explicit **generic** extra-file instead of a bare path string. > > After the release-please-action v5 upgrade, bare `.yaml` entries use the YAML parse/reserialize updater, which broke releases by stripping `# x-release-please-version` markers and comments and rewriting the example app version incorrectly. The generic updater keeps marker-based line replacement so only the pinned SDK dependency line (e.g. `launchdarkly_flutter_client_sdk: 4.16.0`) bumps on release, matching the behavior from before #262. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit a5f7c5b. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
LaunchDarklyReleaseBot
force-pushed
the
release-please--branches--main--components--launchdarkly_flutter_client_sdk
branch
from
59351f2 to
cd9dc43
Compare
tanderson-ld
approved these changes
Jun 4, 2026
tanderson-ld
deleted the
release-please--branches--main--components--launchdarkly_flutter_client_sdk
branch
Contributor
Author
|
🤖 Created releases: 🌻 |
LaunchDarklyReleaseBot
added
autorelease: tagged
and removed
autorelease: pending
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 I have created a release beep boop
4.17.0 (2026-06-04)
Features
This PR was generated with Release Please. See documentation.
Note
Low Risk
Version and changelog-only changes from Release Please; no new runtime logic in this diff.
Overview
Release 4.17.0 for
launchdarkly_flutter_client_sdk: bumps the package and example app from 4.16.0 → 4.17.0, updates.release-please-manifest.json, and sets the reportedsdkVersioninld_client.dart.The changelog entry records the shipped feature from #280: FDv2 connection-mode resolution wired through the Flutter SDK (no additional implementation changes appear in this diff).
Reviewed by Cursor Bugbot for commit cd9dc43. Bugbot is set up for automated code reviews on this repo. Configure here.