feat(symbols): add Flutter (Dart AOT) symbol upload (--type flutter)#756
Open
abelonogov-ld wants to merge 10 commits into
Open
feat(symbols): add Flutter (Dart AOT) symbol upload (--type flutter)#756abelonogov-ld wants to merge 10 commits into
abelonogov-ld wants to merge 10 commits into
Conversation
Rename the symbol-map package/format from ldsm to dsymmap (magic DSMP), append the .dsymmap extension to the apple upload key, and accept apple/ios/dsym aliases for the --type flag. Co-authored-by: Cursor <cursoragent@cursor.com>
Parse Flutter ELF app.<arch>.symbols files (debug/elf + debug/dwarf), extract the Dart build id (.note.gnu.build-id) and DWARF, and compile them into the compact .dartmap symbol map (dsymmap codec). Upload to the Symbols Id lane (keyed by build id) and the Version lane (version + platform), and support local generation via `symbols generate`. Co-authored-by: Cursor <cursoragent@cursor.com>
Parse Flutter ELF app.<arch>.symbols files (debug/elf + debug/dwarf), extract the Dart build id (.note.gnu.build-id) and DWARF, and compile them into the compact .dartmap symbol map (dsymmap codec). Upload to the Symbols Id lane (keyed by build id) and the Version lane (version + platform), and support local generation via `symbols generate`. Co-authored-by: Cursor <cursoragent@cursor.com>
…y/ldcli into andrey/flutter-symbols * 'andrey/flutter-symbols' of ssh://github.com/launchdarkly/ldcli: feat(symbols): add Flutter (Dart AOT) symbol upload (--type flutter) panic fix fix demagling refactor(symbols): rename ldsm to dsymmap + apple type aliases apple dsym ingest
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a0abe1b. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ldcli symbols upload --type flutter(aliases:dart). Parses Flutter ELFapp.<arch>.symbolsfiles with the Go stdlibdebug/elf+debug/dwarf, extracts the Dart build id from.note.gnu.build-idand the DWARF debug info, and compiles them into the compact.dartmapsymbol map (reusing thedsymmapcodec from the Apple work, already onmain).symbols generatefor local.dartmapoutput.Test plan
go test ./internal/symbols/flutter/... ./cmd/symbols/...ldcli symbols upload --type flutter --path <split-debug-info dir>and verify maps land in both lanesPairs with the backend Flutter enhancer (observability#1500) and Flutter SDK (observability-sdk#691) PRs.
Made with Cursor