docs(e2e/android): document --include-sources for mapping uploads#692
Open
abelonogov-ld wants to merge 1 commit into
Open
docs(e2e/android): document --include-sources for mapping uploads#692abelonogov-ld wants to merge 1 commit into
abelonogov-ld wants to merge 1 commit into
Conversation
Explains why Android needs --source-path at all (an R8 mapping records no file paths, unlike a dSYM's DWARF), how files are keyed by their declared package so a Kotlin file in a mismatched directory still resolves, the skipped directories and size limits, and that the flag is off by default because it stores source in LaunchDarkly. Also notes the side benefit: R8's 'SourceFile' placeholder forces the backend to guess .java, and a resolved source replaces that guess with the real path, so Kotlin frames finally show .kt. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents the
--include-sources/--source-pathflags added in launchdarkly/ldcli#758, which upload your.java/.ktfiles so the errors page can show the code around each retraced frame.Explains why Android needs
--source-pathat all (an R8 mapping records no file paths, unlike a dSYM's DWARF), how files are keyed by their declared package so a Kotlin file in a directory that doesn't mirror its package still resolves, the skipped directories and size limits, and that the flag is off by default because it stores your source in LaunchDarkly.Also notes the side benefit: R8's
SourceFileplaceholder forces the backend to guess.javafor every frame, and a resolved source replaces that guess with the real path — so Kotlin frames finally show.kt.Made with Cursor