[pricing] feat: add dynamic savings badge on yearly toggle#7800
[pricing] feat: add dynamic savings badge on yearly toggle#7800akshatsinghai6682-sketch wants to merge 2 commits into
Conversation
|
Preview deployment for PR #7800 removed. This PR preview was automatically pruned because we keep only the 6 most recently updated previews on GitHub Pages to stay within deployment size limits. If needed, push a new commit to this PR to generate a fresh preview. |
|
@akshatsinghai6682-sketch also can you match the border color like white to ensure the consistency |
|
@NSTKrishna Added white border to the savings badge for consistency. Please take a look! |
also i suggest one more thing to do default color of monthly and yearly should be white because there is not black text in the whole page it look off |
|
@NSTKrishna Updated the default text color of Monthly and Yearly to white for consistency. Please take a look! |
bordercolor is not working check it again |
in mine it is showing i have checked the preview actually tell me if some problem is still coming
|
|
i was say to add the border color monthly , yearly div currently it is blue |
ok i will add it and that border of the save 15% badge is it looking good according to website? |
|
@NSTKrishna there is a network issue here i could submit you updated pr by 10:30 for sure thanks for the feedback |
chaitanyamedidar
left a comment
chaitanyamedidar
left a comment
There was a problem hiding this comment.
@akshatsinghai6682-sketch , was this issue/approach discussed with any member? As this issue hasn't been assigned yet, thus not validated.
I have few follow ups, your acceptance criteria mentions "Badge disappears or changes when Monthly toggle is selected". On the contrary, showing savings awareness on the Monthly toggle too could help users decide earlier. Thoughts?
|
@chaitanyamedidar i will surely do the change and submit by new pr its still not discussed i guess i will discuss it in next monday website meeting thanks for the feedback |
|
@akshatsinghai6682-sketch You could bring it up on the thread where you've mentioned this PR. |
I have shared link of this in slack and asked for review |
|
"@chaitanyamedidar I have addressed your feedback:
|
Addressed the feedback please review it thank you |
|
@akshatsinghai6682-sketch, why do we need this? I still don't fully understand the use case. Could you please bring this up during Monday's meeting so we can discuss it in more detail? |
|
@saurabhraghuvanshii Sure! I'll bring this up in Monday's meeting. Quick context: Currently when users switch to Yearly billing, Happy to discuss further on the call! |
|
@akshatsinghai6682-sketch Thank you for your contribution! Let's discuss this during the website call tomorrow at 5:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂 |
|
sure @Bhumikagarggg |
|
Had technical issues during today's meeting and couldn't
|
|
On initial load, the currency dropdown text is overlapping and looks broken. Could you please fix this issue? |
|
sure @Sbragul26 |
|
"Hi @Sbragul26! I've fixed the currency dropdown overlap issue. Please see before/after screenshots above — the dropdown now displays cleanly without any text overlap. The Save Upto 15% badge is also working correctly! " 
now there is no loading problem thanks for the feedback please review this whenever possible |
i have fixed the issue but should i open another pr for this issue or in this only it would merge? |
Open a new pr |
actually @Sbragul26 so he was telling to update in same pr |
Bhumikagarggg
left a comment
Bhumikagarggg
left a comment
There was a problem hiding this comment.
@akshatsinghai6682-sketch Thanks for the contribution. I approve this PR. Just one request: please squash the 14 commits into a single commit before merging.
akshatsinghai6682-sketch
force-pushed
the
feat/pricing-yearly-savings-badge
branch
from
f37c06d to
26567da
Compare
akshatsinghai6682-sketch
force-pushed
the
feat/pricing-yearly-savings-badge
branch
from
85c3781 to
1966f9c
Compare
rishiraj38
left a comment
rishiraj38
left a comment
There was a problem hiding this comment.
This branch appears to have picked up some unrelated commits. Could you please clean it up so that only the intended changes remain?
akshatsinghai6682-sketch
force-pushed
the
feat/pricing-yearly-savings-badge
branch
2 times, most recently
from
b609d1a to
3ec4ff1
Compare
Signed-off-by: Akshat Singhai <akshatsinghai6682@gmail.com>
akshatsinghai6682-sketch
force-pushed
the
feat/pricing-yearly-savings-badge
branch
from
217ba2c to
5b4d596
Compare
|
@Bhumikagarggg Done, I've cleaned up the branch and squashed the changes into a single commit. The branch has been force-pushed with only the intended pricing badge changes. Thanks for the review and approval! |
I've cleaned up the branch and removed the unrelated commits. The PR now contains only the intended pricing badge changes in a single commit. Could you please take another look? |
|
Thanks, @akshatsinghai6682-sketch. We don't need this for now, but I appreciate the time and effort you've put into it. Thank you for your contribution and willingness to help. It's greatly appreciated! |
|
ok @saurabhraghuvanshii thank you |
7 participants
Description
This PR fixes #7799
Added a dynamic "Save X%" badge on the Yearly toggle button in the pricing page.
The badge appears when Yearly is selected and dynamically calculates the maximum
savings percentage from the plan data, so it always reflects accurate savings.
Changes
getMaxSavingsPercent()function to dynamically calculate max savings from plan dataScreenshots
Notes for Reviewers
The badge is only visible when Yearly is active. The savings percentage is calculated
dynamically from
optionsplan data — not hardcoded — so it will automaticallyupdate if plan prices change.
Signed commits