Skip to content

Add a Makefile to workflow #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
indevi wants to merge 3 commits into
base: master
Choose a base branch
from
+16 −0
Open

Add a Makefile to workflow #43

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d321fb7
Add a Makefile to workflow
Apr 9, 2026
aa8e9d1
Address review on before adding Makefile to workflow
Apr 13, 2026
8b59bb0
Update Makefile to streamline site setup
indevi Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
# .PHONY: Declares phony targets, which are commands that don't produce a file with the same name.
.PHONY: install start build test clean

# Install project dependencies
install:
npm install

Copy link
Copy Markdown
Member

@saurabhraghuvanshii saurabhraghuvanshii Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add make site it should run both npm install then npm run dev

Copy link
Copy Markdown
Author

@indevi indevi Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hope this is what you are looking for here @saurabhraghuvanshii

Copy link
Copy Markdown
Member

@saurabhraghuvanshii saurabhraghuvanshii Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@indevi this is good but can you refer this https://github.com/layer5io/layer5/blob/master/Makefile once

Copy link
Copy Markdown
Author

@indevi indevi Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refered and added a echo message

# Start the development server
start:
Copy link
Copy Markdown
Member

@saurabhraghuvanshii saurabhraghuvanshii Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@indevi change it to dev

Copy link
Copy Markdown
Author

@indevi indevi Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

npm run dev

# Build the project for production
build:
npm run build

# Run project tests
test:
npm run test

# Clean up build artifacts and installed modules
clean:
Copy link
Copy Markdown
Member

@saurabhraghuvanshii saurabhraghuvanshii Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@indevi it should be coming from package.json means add a clean script in package.json then use like npm run clean.

Copy link
Copy Markdown
Author

@indevi indevi Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay considering the scope, its best i remove clean command

rm -rf dist node_modules
Loading