Skip to content

chore: rename some lemmas containing not_unit - #42386

Open
NoahW314 wants to merge 2 commits into
leanprover-community:masterfrom
NoahW314:DvdNotUnit
Open

chore: rename some lemmas containing not_unit#42386
NoahW314 wants to merge 2 commits into
leanprover-community:masterfrom
NoahW314:DvdNotUnit

Conversation

@NoahW314

@NoahW314 NoahW314 commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

@github-actions

github-actions Bot commented Aug 2, 2026

Copy link
Copy Markdown

PR summary 8ee0ed7068

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ DvdNotUnit.not_isUnit
+ not_irreducible_of_not_isUnit_dvdNotUnit

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 8ee0ed7).

  • +2 new declarations
  • −0 removed declarations
+DvdNotUnit.not_isUnit
+not_irreducible_of_not_isUnit_dvdNotUnit

No changes to strong technical debt.

No changes to weak technical debt.

Current commit 8ee0ed7068
Reference commit 68302e4c4f

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-ring-theory Ring theory label Aug 2, 2026
@NoahW314 NoahW314 changed the title chore: rename DvdNotUnit.not_unit to DvdNotUnit.not_isUnit chore: rename some lemmas containing not_unit Aug 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-ring-theory Ring theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant