Skip to content

refactor(RingTheory/DedekindDomain): make IsDedekindDomainInv private - #42392

Open
plp127 wants to merge 2 commits into
leanprover-community:masterfrom
plp127:aliu/dedekind-inv
Open

refactor(RingTheory/DedekindDomain): make IsDedekindDomainInv private#42392
plp127 wants to merge 2 commits into
leanprover-community:masterfrom
plp127:aliu/dedekind-inv

Conversation

@plp127

@plp127 plp127 commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Make IsDedekindDomainInv private, because is the same as IsDedekindDomain. See Zulip.


Open in Gitpod

@github-actions github-actions Bot added t-ring-theory Ring theory tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip labels Aug 3, 2026
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

PR summary b00e5fa3af

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ isDedekindDomain_iff_mul_inv_cancel
- isDedekindDomain

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit b00e5fa).

  • +1 new declarations
  • −8 removed declarations
-IsDedekindDomainInv
-IsDedekindDomainInv.commGroupWithZero
-IsDedekindDomainInv.dimensionLEOne
-IsDedekindDomainInv.integrallyClosed
-IsDedekindDomainInv.isDedekindDomain
-IsDedekindDomainInv.isNoetherianRing
-isDedekindDomainInv_iff
-isDedekindDomain_iff_isDedekindDomainInv
+isDedekindDomain_iff_mul_inv_cancel

No changes to strong technical debt.

Decrease in weak tech debt: (relative, absolute) = (1.00, 0.00)
Current number Change Type (weak)
5046 -1 exposed public sections

Current commit b00e5fa3af
Reference commit 18f56bef53

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-ring-theory Ring theory tech debt Tracking cross-cutting technical debt, see e.g. the "Technical debt counters" stream on zulip

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant