fix(Algebra/GroupWithZero/Associated): de-abbrev Associates - #42394
Open
SnirBroshi wants to merge 1 commit into
Open
fix(Algebra/GroupWithZero/Associated): de-abbrev Associates#42394SnirBroshi wants to merge 1 commit into
abbrev Associates#42394SnirBroshi wants to merge 1 commit into
Conversation
PR summary e23e51da8dImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
| Current number | Change | Type (strong) |
|---|---|---|
| 6986 | -1 | backward.isDefEq.respectTransparency |
Current commit e23e51da8d
Reference commit 375d54da29
This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associatesis anabbrevforQuotient _, but there are manyinstances defined on it.Some of them create diamonds with general
Quotientinstances:Inhabited,Unique, and most notablyPreorder.While
Associateshas aPreorderinstance that uses the divisibility relation, any monoid with aPreorderwill have its ordering lifted to theQuotient. So currentlyAssociates ℕhas two differentLEorders defined on it that disagree on2 ≤ 3.This changes
Associatesto adeftagged with@[implicit_reducible].The
nonZeroDivisorsproof is now a bit awkward, since theEquivworks forQuotients butsimprefuses to evaluate theEquivbecauseAssociateelements are multiplied butQuotientdoesn't have that multiplication. Thoughrwworks thanks to@[implicit_reducible].