You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
--- FAIL: TestConfigValidation (0.04s)
--- FAIL: TestConfigValidation/mtca.json (0.00s)
main_test.go:72: Failed to validate config file "mtca.json": open ../../test/config/mtca.json: no such file or directory
FAIL
This is because TestConfigValidation checks cmd.AvailableConfigValidators(), and the mtca component is gated on //go:build go1.27, and mtca.json is only available for the plain config/ directory. That worked out fine before because we used gotip for all config-next build phases, but now we need to have a copy of mtca.json for config/.
--- FAIL: TestPublish (0.06s)
mtpublisher_test.go:200: selecting the latest checkpoint: failed to select one checkpoints: sql: no rows in result set
FAIL
I believe this is a race between the mtca and mtpublisher unittests, the same as the race between the ra and sa ones. Not sure why this is only showing up under Go 1.27; perhaps we got lucky before.
I believe this is a race between the mtca and mtpublisher unittests, the same as the race between the ra and sa ones. Not sure why this is only showing up under Go 1.27; perhaps we got lucky before.
Is there any chance we can avoid repeating our RA unittest mistakes in the MTCA and MTPub? Those two components interact with very few database tables; can we just fake those in memory?
Is there any chance we can avoid repeating our RA unittest mistakes in the MTCA and MTPub? Those two components interact with very few database tables; can we just fake those in memory?
Yep, I think we should do better here, as a separate PR.
The golangci-lint failures are real, because we need to update to a golangci version with Go 1.27 support. Doing that produces a bunch of new findings; I'm working on fixing those.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.