Fix: Enclose SET_ISSUE_ID with single quotes#53
Merged
Conversation
Signed-off-by: Kevin Sandi <ksandi@contractor.linuxfoundation.org>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a shell scripting issue by adding single quotes around the SET_ISSUE_ID environment variable in a conditional check, enabling the variable to contain complex strings with spaces and special characters as required by ONAP projects.
- Added single quotes around
${{ env.SET_ISSUE_ID }}in the bash conditional statement
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
askb
approved these changes
Sep 17, 2025
askb
left a comment
askb
left a comment
Contributor
There was a problem hiding this comment.
I'm not sure if this is required, if this is tested then lets go ahead.
Contributor
Author
|
Yes I tested it in my fork. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow passing more complex strings through the SET_ISSUE_ID variable, some projects like ONAP require a title before the real Issue ID, e.g. "Issue-ID: CIMAN-33"