Skip to content

Resize wire chunk to bytes written, cached size is an allocation bound. #915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evoskuil merged 1 commit into from
Sep 9, 2026
Merged

Resize wire chunk to bytes written, cached size is an allocation bound. #915

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion include/bitcoin/database/impl/query/archive/wire_reader.ipp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ bool CLASS::get_wire_block(bytewriter& sink, const header_link& link,

// These convenience wrappers are made practical by size caching for block and
// tx for both nominal and witness wire encodings (and fixed size headers).
// Intermediate objects (input, output, witness) have a size prefix
// Intermediate objects (input, output, witness) have a size prefix.

TEMPLATE
data_chunk CLASS::get_wire_header(const header_link& link) const NOEXCEPT
Expand Down Expand Up @@ -175,6 +175,8 @@ data_chunk CLASS::get_wire_tx(const tx_link& link, bool witness) const NOEXCEPT
if (!get_wire_tx(out, link, witness) || !out)
return {};

// Resize in case tx is pruned.
data.resize(out.get_write_position());
return data;
}

Expand All @@ -193,6 +195,8 @@ data_chunk CLASS::get_wire_block(const header_link& link,
if (!get_wire_block(out, link, witness) || !out)
return {};

// Resize in case tx is pruned.
data.resize(out.get_write_position());
return data;
}

Expand Down