Skip to content

Rename protocol_block_in_31800::check() to ::identify(). #1021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evoskuil merged 1 commit into from
May 29, 2026
Merged

Rename protocol_block_in_31800::check() to ::identify(). #1021

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/bitcoin/node/protocols/protocol_block_in_31800.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ class BCN_API protocol_block_in_31800
const network::messages::peer::block::cptr& message) NOEXCEPT;

private:
code check(const system::chain::block_view& block,
code identify(const system::chain::block_view& block,
const system::chain::context& ctx, bool bypass) const NOEXCEPT;

void send_get_data(const map_ptr& map, const job::ptr& job) NOEXCEPT;
Expand Down
6 changes: 3 additions & 3 deletions src/protocols/protocol_block_in_31800.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ bool protocol_block_in_31800::handle_receive_block(const code& ec,
const auto link = it->link;
const auto height = it->context.height;

// Check block.
// Identify block.
// ........................................................................

const auto checked = is_under_checkpoint(height);
Expand All @@ -300,7 +300,7 @@ bool protocol_block_in_31800::handle_receive_block(const code& ec,
// only stored when a strong header has been stored, later to be found out
// as invalid and not malleable. Stored invalidity prevents repeat
// processing of the same invalid chain but is not necessary or desirable.
if (const auto code = check(block, it->context, bypass))
if (const auto code = identify(block, it->context, bypass))
{
if (code == system::error::invalid_transaction_commitment ||
code == system::error::invalid_witness_commitment)
Expand Down Expand Up @@ -362,7 +362,7 @@ bool protocol_block_in_31800::handle_receive_block(const code& ec,
// Header is checked by organize, Check/Accept/Connect are called by validate.
// While check could be called here, it's more optimal to defer to validate, as
// requiring only identity here allows the use of the simplified block_view.
code protocol_block_in_31800::check(const chain::block_view& block,
code protocol_block_in_31800::identify(const chain::block_view& block,
const chain::context& ctx, bool) const NOEXCEPT
{
code ec{};
Expand Down
Loading