Skip to content

Add support for Testnet4 #1034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thecodefactory wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −1
Open

Add support for Testnet4 #1034

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/chasers/chaser_block.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,11 @@ code chaser_block::validate(const block& block,
if ((ec = header.check(
setting.timestamp_limit_seconds,
setting.proof_of_work_limit,
state.height(),
state.timestamp(),

@evoskuil evoskuil Jun 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These 2 are problematic here, as this is a context free check override (there is no contextual header::check(..)). So this needs to move to header::accept(...) where these values are passed via context.

state.previous_block_timestamp(),

@evoskuil evoskuil Jun 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a more significant issue, since it is runtime context that is not part of context. Making it part of runtime context has an impact on query (database) for population of context for chain_state initialization (and possibly elsewhere).

@thecodefactory thecodefactory Jun 7, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In an earlier version of this code, I did make the database changes (locally) to add previous_block_time (pbt) so that it could be used by the context in header::accept. If that's the route we need to go, I can modernize that, but mostly I thought of it as a learning exercise

@evoskuil evoskuil Jun 7, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is simpler actually, no database impact. The population queries already always populate the required state because of the MTP requirement. So just add this to context and obtain the context from the chain_state for header validation (already the case) and it's populated:
chain::context chain::chain_state::context() const NOEXCEPT;

@thecodefactory thecodefactory Jun 7, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I'm following this last part. I think if we add anything to the context (i.e. new members), it will affect the database and those changes will be needed (i.e. previous_block_timestamp and retargeting_interval).

@thecodefactory thecodefactory Jun 7, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding members to the context and using header::accept along with this https://github.com/thecodefactory/libbitcoin-database/tree/testnet4 allows me to also sync testnet4

@thecodefactory thecodefactory Jun 7, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there's a way to do it w/o changing anything in database, I'd prefer that, so let me know

@evoskuil evoskuil Jun 8, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chain_state already populates the last 11 blocks worth of timestamps in order to maintain a rolling (no database hit) MTP value. So the value is already present, just needs to be set into context is is is obtained from chain_state.

setting.retargeting_interval(),
Comment thread
evoskuil marked this conversation as resolved.
setting.forks.bip94,
setting.forks.scrypt_proof_of_work)))
return ec;

Expand Down
7 changes: 6 additions & 1 deletion src/chasers/chaser_header.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,11 @@ code chaser_header::validate(const header& header,
if (const auto ec = header.check(
settings().timestamp_limit_seconds,
settings().proof_of_work_limit,
state.height(),
state.timestamp(),
state.previous_block_timestamp(),
settings().retargeting_interval(),

@evoskuil evoskuil Jun 7, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments as above.

settings().forks.bip94,
settings().forks.scrypt_proof_of_work))
return ec;

Expand Down Expand Up @@ -242,4 +247,4 @@ BC_POP_WARNING()
// Minimum block versions (bip90 disabled).
// Minimum block version [1] changed to [2] at [227931:000000000000024b89b42a942fe0d9fea3bb44ab7bd1b19115dd6a759c0808b8]
// Minimum block version [2] changed to [3] at [363725:00000000000000000379eaa19dce8c9b722d46ae6a57c2f1a988119488b50931]
// Minimum block version [3] changed to [4] at [388381:000000000000000004c2b624ed5d7756c508d90fd0da2c7c679febfa6c4735f0]
// Minimum block version [3] changed to [4] at [388381:000000000000000004c2b624ed5d7756c508d90fd0da2c7c679febfa6c4735f0]
Loading