Repository navigation
cmake: bionic has no librt - #156
Merged
LibretroAdmin merged 1 commit intoAug 27, 2026
Merged
Conversation
The android jobs configure but never generate: CMake Error: The following variables are used in this project, but they are set to NOTFOUND: librt, linked by target "common" FindLibc.cmake looks for rt and dl on everything that is not APPLE (the `elseif(Linux)` arm tests a variable nobody sets, so Linux lands in the else too). Android has neither - both are folded into libc - so find_library leaves librt-NOTFOUND sitting in LIBC_LIBRARIES and generation stops.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The android jobs I added in #154 have never got past configure. First it was
find_package(OpenGL REQUIRED), fixed in f5e47ce; now it is one line further along:cmake/FindLibc.cmakelooks forrtanddlon everything that is not APPLE — theelseif(Linux)arm tests a variable nobody ever sets, so Linux falls into theelse()too. Android has neither: bionic folds the timer and dl entry points into libc.find_librarytherefore leaveslibrt-NOTFOUNDinLIBC_LIBRARIES, and generation stops.Everything else on pipeline 104926 is green now, including windows-x64 after 02d30cb, so this is the last one standing.
No other platform changes behaviour: Linux was already falling through to the
else()arm and still does, APPLE and the BSD/else arms are untouched. I have not build-tested this locally — the android NDK is not installed here — so the pipeline is the check.