fix(dashboard): open the chart editor modal from the empty-state Add tile - #28648
Merged
Conversation
…tile The empty dashboard's centered Add tile rendered its own AddTileButton without onNewChart, so New chart navigated away instead of opening the in-dashboard editor. Thread the handler through DashboardTabs and EmptyStateNoTiles. Relates: GLITCH-722
🧪 Test Selection✅ Tests that will run
⏭️ Tests skipped (no relevant file changes detected)
|
|
Your preview environment pr-28648 has been deployed. Preview environment endpoints are available at: |
Preview Environment🌐 URL: https://lightdash-preview-pr-28648.lightdash.okteto.dev 📋 Logs: View in GCP Console 🔧 SSH: |
lightdash-bot
pushed a commit
that referenced
this pull request
Sep 4, 2026
# [2.124.0](2.123.0...2.124.0) (2026-09-04) ### Bug Fixes * **ai:** clarify expression value quoting ([#28639](#28639)) ([e7fc05e](e7fc05e)) * **dashboard:** open the chart editor modal from the empty-state Add tile ([#28648](#28648)) ([ca14cc6](ca14cc6)) * **data-apps:** expose safe external fetch response headers ([#28641](#28641)) ([464f356](464f356)) * **merge:** refuse a merge over a result source cut short at its own limit ([#28642](#28642)) ([9b9451f](9b9451f)) * **query-history:** reserve space while loading so the page stops shifting ([#28652](#28652)) ([4178a38](4178a38)) ### Features * **dashboard:** badge dashboard custom metrics from creation ([#28643](#28643)) ([4333777](4333777))
Collaborator
|
🎉 This PR is included in version 2.124.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates: GLITCH-722
Description:
On an empty dashboard, the centered "Add tile" renders its own
AddTileButton(viaEmptyStateNoTiles) which never receivedonNewChart— so with thedashboard-custom-metricsflag on, "New chart" from the empty state still navigated away instead of opening the in-dashboard editor modal. The header's Add tile worked; the empty state didn't.Threads the same flag-gated handler through
DashboardTabs→EmptyStateNoTiles→AddTileButton, and hoists it into a stablehandleOpenNewChartcallback shared with the header. Flag off:onNewChartstaysundefined, behaviour unchanged.Risk assessment:
High-risk changes require approval from a reviewer other than the author before merging.