Repository navigation
Move Electrum fee rate estimation into a free function - #1164
Open
randomlogin wants to merge 1 commit into
Open
randomlogin wants to merge 1 commit into
randomlogin wants to merge 1 commit into
Conversation
Electrum fee estimation is used both by cbf chain and electrum chain sources, thus we make the function a free one. `ElectrumRuntimeClient::get_fee_rate_cache_update` only needs the runtime, the Electrum client, the network, the update timeout and a logger. Turn it into the free function `get_electrum_fee_rate_cache_update` so the estimation can be run without an `ElectrumRuntimeClient`. The client no longer reads its `config` field after this, so drop the field and the argument threaded through `start`/`new`. No functional change. Co-authored-by: febyeji <yeji.han@sf.snu.ac.kr>
|
I've assigned @tnull as a reviewer! |
2 of 4 tasks
Contributor
Author
|
a) It is the preferred way, and is present: https://github.com/lightningdevkit/ldk-node/pull/828/changes#diff-57e92d1ef2766422873e6720acf66e43a40699b73b9b0ea98071815e8d931bc5R160. b) Yeah, makes sense, I will update the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Electrum fee estimation is used both by cbf chain and electrum chain sources, thus we make the function a free one.
ElectrumRuntimeClient::get_fee_rate_cache_updateonly needs the runtime, the Electrum client, the network, the update timeout and a logger. Turn it into the free functionget_electrum_fee_rate_cache_updateso the estimation can be run without anElectrumRuntimeClient.The client no longer reads its
configfield after this, so drop the field and the argument threaded throughstart/new.No functional change.