Skip to content

Implement MCP ping method#239

Merged
tnull merged 1 commit into
lightningdevkit:mainfrom
benthecarman:mcp-ping
Jul 2, 2026
Merged

Implement MCP ping method#239
tnull merged 1 commit into
lightningdevkit:mainfrom
benthecarman:mcp-ping

Conversation

@benthecarman

Copy link
Copy Markdown
Collaborator

Had fable scan the codebase and call out anything we should add. It refused and fell back to opus but at least it found this.

The MCP spec requires receivers to answer a ping request with an empty result object. Previously every method other than initialize, tools/list, and tools/call fell through to a METHOD_NOT_FOUND error, so a client that health-checks with ping would conclude the server was dead and drop the connection.

This change was made with the assistance of Claude Code.

@benthecarman benthecarman requested a review from tnull July 2, 2026 03:33
@ldk-reviews-bot

ldk-reviews-bot commented Jul 2, 2026

Copy link
Copy Markdown

👋 Thanks for assigning @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@tnull tnull left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, otherwise LGTM

Comment thread ldk-server-mcp/CLAUDE.md
The MCP spec requires receivers to answer a ping request with an empty
result object. Previously every method other than initialize,
tools/list, and tools/call fell through to a METHOD_NOT_FOUND error, so
a client that health-checks with ping would conclude the server was
dead and drop the connection.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@tnull tnull merged commit 9f960bc into lightningdevkit:main Jul 2, 2026
10 checks passed
@benthecarman benthecarman deleted the mcp-ping branch July 2, 2026 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants