Expose payment failure reason on PaymentFailed event - #263
Open
elnafateh wants to merge 3 commits into
Open
Conversation
Adds PaymentFailureReason to the PaymentFailed proto event, mapped from ldk-node's lightning::events::PaymentFailureReason. Covers one item from lightningdevkit#251.
|
👋 Thanks for assigning @benthecarman as a reviewer! |
benthecarman
requested changes
Aug 28, 2026
| } | ||
|
|
||
| #[test] | ||
| fn test_payment_failure_reason_mapping() { |
Collaborator
There was a problem hiding this comment.
This test doesn't really do anything, can we delete
| Some(Event::PaymentFailed(payment_failed)) => { | ||
| // NOTE: exact variant depends on how a receiver-side manual fail propagates; | ||
| // asserting `Some` here, tighten to the specific reason once confirmed locally. | ||
| assert!(payment_failed.reason.is_some()); |
Collaborator
There was a problem hiding this comment.
This test should always produce the same error and we can just assert that error
Co-authored-by: benthecarman <15256660+benthecarman@users.noreply.github.com>
Collaborator
|
Please squash your commits |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes part of #251.
PaymentFailedcurrently drops the reason field that LDK Node already provides. This adds it as an optionalPaymentFailureReasonenum on the proto event, mapped 1:1 fromlightning::events::PaymentFailureReason.PaymentFailureReasonenum inevents.proto, mirrors LDK's variantspayment_failure_reason_to_proto()mapping function, wired into the event handlerThe other items in #251 (splice events, channel snapshot fields, on-chain tx classification, misc fields) are left for follow-up PRs.