Skip to content

Prevent TLS certificate fallback across storage directories - #315

Open
tankyleo wants to merge 1 commit into
lightningdevkit:mainfrom
tankyleo:2026-10-tls-cert-fallback
Open

Prevent TLS certificate fallback across storage directories#315
tankyleo wants to merge 1 commit into
lightningdevkit:mainfrom
tankyleo:2026-10-tls-cert-fallback

Conversation

@tankyleo

@tankyleo tankyleo commented Oct 12, 2026

Copy link
Copy Markdown
Contributor 
    Prevent TLS certificate fallback across storage directories

    A missing TLS certificate file inside a configured storage directory
    should produce an error instead of falling back to the certificate in
    the OS-specific default directory.

    Co-Authored-By: HAL 9000

@tankyleo
Prevent TLS certificate fallback across storage directories
e919ecb 
A missing TLS certificate file inside a configured storage directory
should produce an error instead of falling back to the certificate in
the OS-specific default directory.

Co-Authored-By: HAL 9000
@ldk-reviews-bot

ldk-reviews-bot commented Oct 12, 2026 •
edited
Loading

Copy link
Copy Markdown

👋 Thanks for assigning @benthecarman as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@tankyleo
tankyleo requested a review from benthecarman October 12, 2026 19:22
benthecarman
benthecarman approved these changes Oct 12, 2026
View reviewed changes
Comment thread ldk-server-client/src/config.rs
resolve_base_url, resolve_cert_path, resolve_macaroon, resolve_macaroon_path, Config,
ADMIN_MACAROON_FILE, CONFIG_FILE_SIZE_LIMIT, DEFAULT_GRPC_SERVICE_ADDRESS,
TLS_CERT_FILE_SIZE_LIMIT,
};

@benthecarman benthecarman Oct 12, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benthecarman benthecarman benthecarman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tankyleo @ldk-reviews-bot @benthecarman