You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
LINBEE-30104 | fix: show the effort verdict at every effort level - #27
At low effort the model kept the verdict in thinking, so nothing showed or was reported until the hold blocked an edit; the skill now records it with one printf call and a PostToolUse hook shows it on screen (6/6 real sessions at low/medium/max, 98 hook tests).
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
The verdict extraction regex truncates valid plans containing apostrophes; it needs to read tool_response.stdout instead, with fixtures covering escaped apostrophes.
This PR makes Agentic Advisor effort verdicts visible at every effort level by requiring a dedicated printf call and displaying the verdict through a PostToolUse hook.
Changes:
Updates skill instructions and edit-hold guidance to require the verdict-printing call.
Adds hook handling and tests for verdict display, edit unblocking, and reporting.
Bumps the plugin to version 1.5.2 and documents the fix.
File
Description
tests/agentic-advisor/hooks_test.sh
Adds verdict-display and printf-based reporting tests.
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
Shell-source parsing truncates verdicts containing apostrophes, and supported manual invocations with the feature disabled lack a visible assistant-text fallback.
The skill still explicitly supports invocation by name while LINEARB_AGENTIC_ADVISOR_ENABLED is off (see the Off switch section and README.md:91), but the trigger exits before PostToolUse handling in that configuration. Requiring only printf therefore leaves these explicitly requested verdicts inside the collapsed Bash output, with no display message. Preserve the off switch, but require a visible assistant-text fallback for this supported manual-invocation path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At low effort the model kept the verdict in thinking, so nothing showed or was reported until the hold blocked an edit; the skill now records it with one printf call and a PostToolUse hook shows it on screen (6/6 real sessions at low/medium/max, 98 hook tests).
🤖 Generated with Claude Code