Skip to content

LINBEE-30104 | fix: show the effort verdict at every effort level - #27

Merged
nivSwisa1 merged 2 commits into
mainfrom
LINBEE-30104-verdict-on-screen
Nov 10, 2026
Merged

nivSwisa1 merged 2 commits into
mainfrom
LINBEE-30104-verdict-on-screen

Conversation

@nivSwisa1

Copy link
Copy Markdown
Contributor

At low effort the model kept the verdict in thinking, so nothing showed or was reported until the hold blocked an edit; the skill now records it with one printf call and a PostToolUse hook shows it on screen (6/6 real sessions at low/medium/max, 98 hook tests).

🤖 Generated with Claude Code

….5.2)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings November 10, 2026 09:49

@orca-security-us orca-security-us Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed OSS Licenses high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

@upwind-code-us

upwind-code-us Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Upwind Upwind IaC Scan - ✅ Passed

0 newly introduced misconfigurations · 0 resolved · 0 total in this PR vs main

View full analysis in Upwind Console →

Scan completed in 12s

Scan history (2 scans)
Commit Scanned at New Resolved Net
a184c44 2026-11-10 09:50 UTC 0 0 0
53babf8 < 2026-11-10 09:53 UTC 0 0 0

Last scanned: 53babf8 · 2026-11-10 09:53 UTC

@upwind-code-us

upwind-code-us Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Upwind Upwind Secrets Scan

0 newly introduced secrets · 0 resolved · 3 total in the files this PR changed vs main

Total breakdown: 🔶 3 PII

A secret that has been pushed remains in the repository's history even after the line is removed.

Scan completed in 12s.


Scan history (2 scans)
Commit Scanned at New Resolved Net
a184c44 2026-11-10 09:50 UTC 0 0 0
53babf8 < 2026-11-10 09:53 UTC 0 0 0

Last scanned: 53babf8 · 2026-11-10 09:53 UTC

@upwind-code-us

upwind-code-us Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Upwind Upwind SAST Scan - ✅ Passed

✅ No SAST findings detected

View full analysis in Upwind Console →

Scan completed in 23s

Scan history (2 scans)
Commit Scanned at New Resolved Net
a184c44 2026-11-10 09:50 UTC 0 0 0
53babf8 < 2026-11-10 09:53 UTC 0 0 0

Last scanned: 53babf8 · 2026-11-10 09:53 UTC

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The verdict extraction regex truncates valid plans containing apostrophes; it needs to read tool_response.stdout instead, with fixtures covering escaped apostrophes.

1 open issue
What changed in this PR

This PR makes Agentic Advisor effort verdicts visible at every effort level by requiring a dedicated printf call and displaying the verdict through a PostToolUse hook.

Changes:

  • Updates skill instructions and edit-hold guidance to require the verdict-printing call.
  • Adds hook handling and tests for verdict display, edit unblocking, and reporting.
  • Bumps the plugin to version 1.5.2 and documents the fix.
File Description
tests/​agentic-advisor/​hooks_test.sh Adds verdict-display and printf-based reporting tests.
plugins/​agentic-advisor/​skills/​agentic-advisor/​SKILL.md Requires a dedicated verdict-printing Bash call.
plugins/​agentic-advisor/​hooks/​hooks.json Registers the Bash PostToolUse hook.
plugins/​agentic-advisor/​hooks/​agentic-advisor-trigger.sh Displays verdicts and updates edit-hold guidance.
plugins/​agentic-advisor/​CHANGELOG.md Documents the verdict-visibility fix.
plugins/​agentic-advisor/​.claude-plugin/​plugin.json Updates the plugin version to 1.5.2.

Review effort: Balanced

PostToolUse)
cmd="$(jq -r '.tool_input.command // empty' <<<"$input" 2>/dev/null || true)"
case "$cmd" in *printf*"LinearB: "*) ;; *) exit 0 ;; esac
line="$(printf '%s\n' "$cmd" | grep -oE "> $GRADED_RE[^']*" | head -n 1)"

@MishaKav MishaKav left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…f bash -c

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings November 10, 2026 09:53

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Shell-source parsing truncates verdicts containing apostrophes, and supported manual invocations with the feature disabled lack a visible assistant-text fallback.

1 open issue
1 previously missed issue

In code that hasn't changed since last review

Medium severity Add visible fallback for manual invocation when disabled

plugins/​agentic-advisor/​skills/​agentic-advisor/​SKILL.md:31

The skill still explicitly supports invocation by name while LINEARB_AGENTIC_ADVISOR_ENABLED is off (see the Off switch section and README.md:91), but the trigger exits before PostToolUse handling in that configuration. Requiring only printf therefore leaves these explicitly requested verdicts inside the collapsed Bash output, with no display message. Preserve the off switch, but require a visible assistant-text fallback for this supported manual-invocation path.

Review effort: Balanced

@nivSwisa1
nivSwisa1 merged commit d165789 into main Nov 10, 2026
15 of 16 checks passed
@nivSwisa1
nivSwisa1 deleted the LINBEE-30104-verdict-on-screen branch November 10, 2026 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants