Skip to content

Fix numeric input adapter reconciliation#189

Merged
linkdata merged 2 commits into
mainfrom
fix/176-numeric-input-reconciliation
Jul 20, 2026
Merged

Fix numeric input adapter reconciliation#189
linkdata merged 2 commits into
mainfrom
fix/176-numeric-input-reconciliation

Conversation

@linkdata

Copy link
Copy Markdown
Owner

Summary

  • treat conversion-adjusted numeric adapter no-ops as successful changes
  • reconcile number inputs after integer truncation and float32 rounding
  • preserve redundant-update suppression for canonical unchanged values
  • document the adapter behavior

Fixes #176

Testing

  • go generate ./...
  • go vet ./...
  • gofmt / gofumpt checks
  • staticcheck ./...
  • golangci-lint run ./...
  • gosec ./...
  • JAWS_REQUIRE_NODE=1 go test -race -coverprofile=/private/tmp/jaws-176-coverage.out ./...
  • go build ./...
  • GOOS=linux GOARCH=386 CGO_ENABLED=0 go test -c ./lib/bind (cross-compile; Linux CI executes the 386 tests)

linkdata added 2 commits July 20, 2026 19:30
Add adapter subtests for negative int truncation and uint truncation, and
parameterize the widget reconciliation test over both Number and Range.

Refine the MakeSetterFloat64 doc: the converted value matches the underlying
setter's current value, not the setter itself.
@linkdata
linkdata marked this pull request as ready for review July 20, 2026 18:14
@linkdata
linkdata merged commit 56c7135 into main Jul 20, 2026
7 checks passed
@linkdata
linkdata deleted the fix/176-numeric-input-reconciliation branch July 20, 2026 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Numeric input adapters can leave browser and server values out of sync

1 participant