Fix logits_to_keep support in Qwen2-VL forwards - #1319
Open
Terminator666666 wants to merge 3 commits into
Open
Conversation
Author
|
????(WSL Ubuntu,RTX 5070 Laptop GPU,BF16,?? test/convergence/bf16/test_mini_models_with_logits.py):
????????? tiny Shakespeare(batch size 16,sequence length 128),?????????? ?????:11 ? CPU forward ?????6 ? monkey-patch ?????Ruff/checkstyle/py_compile/git diff --check ???? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
logits_to_keepsupport in the Liger forward replacements for Qwen2-VL and Qwen2.5-VL.The argument was previously captured by
**kwargs, forwarded to the base multimodal model, and ignored when computing logits. The patched forwards now explicitly consume it and select the requested hidden-state positions beforelm_head, matching Transformers 5.8.1 behavior.Details
logits_to_keep=0all-token behavior.Testing Done
make testto ensure correctnessmake checkstyleto ensure code stylemake test-convergenceto ensure convergenceTargeted tests:
The full test and convergence suites were not run locally because this is a forward-compatibility fix validated with small CPU tensors; upstream CI can provide the broader GPU coverage.