Conversation
# Conflicts: # src/otomi-stack.test.ts
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors Git repository connectivity/branch retrieval by centralizing authentication and Git client creation (including support for token-only HTTPS auth), and improves connectivity-test error reporting back to API clients.
Changes:
- Introduces
getAuthenticatedGitClient()to normalize repo URLs and apply SSH/HTTPS auth based on team secrets or internal Gitea credentials. - Refactors branch listing and connectivity testing to use the shared auth/client logic and to propagate/return errors more consistently.
- Updates tests and OpenAPI schema to include an optional
messageinTestRepoConnectresponses.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils/codeRepoUtils.ts | Adds unified authenticated Git client creation and refactors ref extraction. |
| src/utils/codeRepoUtils.test.ts | Updates unit tests to cover the new auth/client behavior and new error propagation. |
| src/otomi-stack.ts | Switches branch retrieval and connectivity tests to the new shared Git client/auth flow and returns failure messages. |
| src/otomi-stack.test.ts | Adds tests for getRepoBranches() and getTestRepoConnect() using the new helpers and cleanup behavior. |
| src/openapi/testrepoconnect.yaml | Extends response schema with a message field for failure details. |
| src/git/connect.ts | Updates getAuthenticatedUrl() typing and supports token-only auth (no username) by embedding token as the URL “username”. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| expect(result).toEqual([]) | ||
| }) | ||
|
|
||
| it('should clean up the SSH key file after fetching branches', async () => { |
Contributor
There was a problem hiding this comment.
shouldn't the keypath also be cleaned up in case an error is thrown?
| if (!username || !accessToken) throw new Error('Username and access token are required for HTTPS authentication') | ||
| url = repoUrl.replace('https://', `https://${encodeURIComponent(username)}:${encodeURIComponent(accessToken)}@`) | ||
| } else throw new Error('Invalid repository URL format. Must be SSH or HTTPS.') | ||
| export function isInteralGiteaURL(repositoryUrl: string, clusterDomainSuffix?: string) { |
Contributor
There was a problem hiding this comment.
not a blocker but this should be isInternalGiteaURL not Iteral. Would recommend to fix if it's not too complex
dennisvankekem
approved these changes
Jul 1, 2026
dennisvankekem
left a comment
dennisvankekem
left a comment
Contributor
There was a problem hiding this comment.
Left some minor comments but the rest looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes the following fixes and improvements:
The refactored code merges the logic of creating a Git client, making it easier in the future to attach and maintain functionality. The chart retrieval could still use refactoring to support SSH in the future.
Note that SSH code repositories are currently not supported, as the OpenAPI validation rejects them.